Remove unfreeze REST endpoint#119227
Conversation
PeteGillinElastic
force-pushed
the
remove-freeze-unfreeze-9.0
branch
3 times, most recently
from
e75badb to
5d0c861
Compare
PeteGillinElastic
added
>breaking
:Data Management/Indices APIs
|
Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled |
PeteGillinElastic
force-pushed
the
remove-freeze-unfreeze-9.0
branch
from
f0b6d78 to
9dad9c1
Compare
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
PeteGillinElastic
force-pushed
the
remove-freeze-unfreeze-9.0
branch
from
9dad9c1 to
7fc0815
Compare
This adds a sentence to `redirects.asciidoc` explaining what frozen indices were - otherwise, everything will point to the message about the unfreeze API having gone away, which is not very helpful. Some cross-references are updated to point to this rather than to the notice about the removal of the unfreeze API.
PeteGillinElastic
force-pushed
the
remove-freeze-unfreeze-9.0
branch
from
7fc0815 to
8d7d3cb
Compare
elasticsearchmachine
added
the
Team:Data Management (obsolete)
|
Pinging @elastic/es-data-management (Team:Data Management) |
| @@ -1,67 +0,0 @@ | |||
| { | |||
| "indices.unfreeze":{ | |||
There was a problem hiding this comment.
I have no idea how the clients spec handles removals, but we should maybe check there also after this is merged?
There was a problem hiding this comment.
Yeah, good point. I believe that the change will get automatically mirrored to https://github.com/elastic/elasticsearch-specification/tree/main/specification/_json_spec. That may cause validation errors which I guess would be solved by also removing https://github.com/elastic/elasticsearch-specification/tree/main/specification/indices/unfreeze.
There was a problem hiding this comment.
Thanks @dakrone for this comment! Turns out the validation errors are breaking our sync, I removed this API manually in elastic/elasticsearch-specification#3552.
There was a problem hiding this comment.
Oops, sorry about that @pquentin, I thought this was something we could do safely as a follow-up!
There was a problem hiding this comment.
No worries I thought so too. We haven't removed an API in years and our tooling isn't ready for it :) Hopefully we will merge the two specs soon ™️
This adds a sentence to `redirects.asciidoc` explaining what frozen indices were - otherwise, everything will point to the message about the unfreeze API having gone away, which is not very helpful. Some cross-references are updated to point to this rather than to the notice about the removal of the unfreeze API. ES-9736 #comment Removed `_unfreeze` REST endpoint in elastic#119227
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
|
@PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
No, frozen indices were never a thing in serverless. |
The frozen index API was removed in Elasticsearch, causing the documentation link to return 404. ## Changes - Removed broken `operation-indices-unfreeze` API link from badge filter descriptions (2 occurrences) - Updated text from "follower index, rollup index, or frozen" to "follower index or rollup index" - Applied consistently across both serverless and stack documentation tabs <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Update broken API link on Index basics page</issue_title> > <issue_description>On the [Index basics](https://www.elastic.co/docs/manage-data/data-store/index-basics) page, the `frozen` link to the API docs results in a 404. </issue_description> > > <agent_instructions>Remove the link that 404's and update the text in that sentence accordingly</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@lcawl</author><body> > FYI That API was removed in elastic/elasticsearch#119227 and there's rationale for the removal in https://www.elastic.co/guide/en/elasticsearch/reference/8.19/unfreeze-index-api.html</body></comment_new> > <comment_new><author>@bmorelli25</author><body> > sorry this is easy</body></comment_new> > </comments> > </details> - Fixes #3354 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bmorelli25 <5618806+bmorelli25@users.noreply.github.com>
5 participants
N.B. There is cleanup work we can do as a follow-up, but this is the main user-visible change.